Porting WRF-SFIRE fuel moisture model to WRF4 - Revision history

Jmandel: /* Standard */

2019-11-24T21:32:28Z

Standard

← Older revision		Revision as of 21:32, 24 November 2019
Line 51:		Line 51:
	==Fortran==		==Fortran==
	===Standard===		===Standard===
	https://gcc.gnu.org/wiki/GFortranStandards		* https://gcc.gnu.org/wiki/GFortranStandards
			* [https://wg5-fortran.org/N001-N1100/N692.pdf Fortran 90]

	===Namelist===		===Namelist===
	https://stackoverflow.com/questions/10566010/formatting-2d-arrays-in-a-fortran-namelist-input-file		https://stackoverflow.com/questions/10566010/formatting-2d-arrays-in-a-fortran-namelist-input-file

Jmandel: /* Namelist */

2019-11-24T21:26:52Z

Namelist

← Older revision		Revision as of 21:26, 24 November 2019
Line 49:		Line 49:


	==Namelist==		==Fortran==
			===Standard===
			https://gcc.gnu.org/wiki/GFortranStandards
			===Namelist===
	https://stackoverflow.com/questions/10566010/formatting-2d-arrays-in-a-fortran-namelist-input-file		https://stackoverflow.com/questions/10566010/formatting-2d-arrays-in-a-fortran-namelist-input-file

Jmandel: /* Continued progress */

2019-11-24T21:25:26Z

Continued progress

← Older revision		Revision as of 21:25, 24 November 2019
Line 47:		Line 47:
	==Continued progress==		==Continued progress==
	The WRF4 code with the fuel moisture model from wrf-fire is being created in {{wrf-fire-merge-branch\|fuel-moisture-model}} and testing is in progress. Note that the merge is started from {{wrf-branch\|develop}} as requested in [https://github.com/wrf-model/WRF/wiki/Workflow-for-WRF-Code-Modification WRF instructions]. The current WRF is at {{wrf-fire-merge-tag\|v4.0.3}} which is few commits behind {{wrf-branch\|develop}}.		The WRF4 code with the fuel moisture model from wrf-fire is being created in {{wrf-fire-merge-branch\|fuel-moisture-model}} and testing is in progress. Note that the merge is started from {{wrf-branch\|develop}} as requested in [https://github.com/wrf-model/WRF/wiki/Workflow-for-WRF-Code-Modification WRF instructions]. The current WRF is at {{wrf-fire-merge-tag\|v4.0.3}} which is few commits behind {{wrf-branch\|develop}}.


			==Namelist==
			https://stackoverflow.com/questions/10566010/formatting-2d-arrays-in-a-fortran-namelist-input-file

	==See also==		==See also==

Jmandel: /* Preparing pull request */

2019-02-08T03:57:10Z

Preparing pull request

← Older revision		Revision as of 03:57, 8 February 2019
Line 3:		Line 3:
	* http://www2.mmm.ucar.edu/wrf/users/testing.html Testing requirements		* http://www2.mmm.ucar.edu/wrf/users/testing.html Testing requirements
	* http://www2.mmm.ucar.edu/wrf/users/contrib_info.php Information for WRF contributors (outdated but still relevant)		* http://www2.mmm.ucar.edu/wrf/users/contrib_info.php Information for WRF contributors (outdated but still relevant)
			* https://github.com/wrf-model/WRF/wiki/Making-a-good-pull-request-message
	* [https://blog.jaraco.com/how-to-write-perfect-pull-request/ How to write the perfect pull request]		* [https://blog.jaraco.com/how-to-write-perfect-pull-request/ How to write the perfect pull request]

Jmandel: /* Preparing pull request */

2019-02-08T03:55:17Z

Preparing pull request

← Older revision		Revision as of 03:55, 8 February 2019
Line 3:		Line 3:
	* http://www2.mmm.ucar.edu/wrf/users/testing.html Testing requirements		* http://www2.mmm.ucar.edu/wrf/users/testing.html Testing requirements
	* http://www2.mmm.ucar.edu/wrf/users/contrib_info.php Information for WRF contributors (outdated but still relevant)		* http://www2.mmm.ucar.edu/wrf/users/contrib_info.php Information for WRF contributors (outdated but still relevant)
			* [https://blog.jaraco.com/how-to-write-perfect-pull-request/ How to write the perfect pull request]

	==Initial progress==		==Initial progress==
	* I started {{wrf-fire-merge-branch\|fuel-moisture-model}} from {{wrf-branch\|develop}} as requested in [https://github.com/wrf-model/WRF/wiki/Workflow-for-WRF-Code-Modification WRF instructions]. Note that the current WRF is at {{wrf-fire-merge-tag\|v4.0.3}} which is a few commits behind {{wrf-branch\|develop}}.		* I started {{wrf-fire-merge-branch\|fuel-moisture-model}} from {{wrf-branch\|develop}} as requested in [https://github.com/wrf-model/WRF/wiki/Workflow-for-WRF-Code-Modification WRF instructions]. Note that the current WRF is at {{wrf-fire-merge-tag\|v4.0.3}} which is a few commits behind {{wrf-branch\|develop}}.

Jmandel: /* See also */

2019-02-08T03:53:00Z

Jmandel at 18:58, 3 February 2019

2019-02-03T18:58:49Z

← Older revision		Revision as of 18:58, 3 February 2019
Line 1:		Line 1:
	[[Category:WRF-Fire merge]]		[[Category:WRF-Fire merge]]
			==Preparing pull request==
			* http://www2.mmm.ucar.edu/wrf/users/testing.html Testing requirements
			* http://www2.mmm.ucar.edu/wrf/users/contrib_info.php Information for WRF contributors (outdated but still relevant)
	==Initial progress==		==Initial progress==
	* I started {{wrf-fire-merge-branch\|fuel-moisture-model}} from {{wrf-branch\|develop}} as requested in [https://github.com/wrf-model/WRF/wiki/Workflow-for-WRF-Code-Modification WRF instructions]. Note that the current WRF is at {{wrf-fire-merge-tag\|v4.0.3}} which is a few commits behind {{wrf-branch\|develop}}.		* I started {{wrf-fire-merge-branch\|fuel-moisture-model}} from {{wrf-branch\|develop}} as requested in [https://github.com/wrf-model/WRF/wiki/Workflow-for-WRF-Code-Modification WRF instructions]. Note that the current WRF is at {{wrf-fire-merge-tag\|v4.0.3}} which is a few commits behind {{wrf-branch\|develop}}.

Jmandel: /* Continued progress */

2019-02-03T18:55:21Z

Continued progress

← Older revision		Revision as of 18:55, 3 February 2019
Line 40:		Line 40:

	==Continued progress==		==Continued progress==
	The WRF4 code with the fuel moisture model from wrf-fire is being created in {{wrf-fire-merge-branch\|fuel-moisture-model}}~~. It~~ is ~~not ready for testing yet~~. Note that the merge is started from {{wrf-branch\|develop}} as requested in [https://github.com/wrf-model/WRF/wiki/Workflow-for-WRF-Code-Modification WRF instructions]. The current WRF is at {{wrf-fire-merge-tag\|v4.0.3}} which is few commits behind {{wrf-branch\|develop}}.		The WRF4 code with the fuel moisture model from wrf-fire is being created in {{wrf-fire-merge-branch\|fuel-moisture-model}} and testing is in progress. Note that the merge is started from {{wrf-branch\|develop}} as requested in [https://github.com/wrf-model/WRF/wiki/Workflow-for-WRF-Code-Modification WRF instructions]. The current WRF is at {{wrf-fire-merge-tag\|v4.0.3}} which is few commits behind {{wrf-branch\|develop}}.

	==See also==		==See also==

Jmandel: Reverted edits by Jmandel (talk) to last revision by Afarguell

2019-02-03T18:50:57Z

Reverted edits by Jmandel (talk) to last revision by Afarguell

← Older revision		Revision as of 18:50, 3 February 2019
Line 1:		Line 1:
	[[Category:WRF-Fire merge]]		[[Category:WRF-Fire merge]]
	~~<div class="NavFrame collapsed">~~		==Initial progress==
	~~<div class="NavHead">[Initial stage notes]</div>~~
	~~<div class="NavContent">~~
	[
	===Initial progress===
	* I started {{wrf-fire-merge-branch\|fuel-moisture-model}} from {{wrf-branch\|develop}} as requested in [https://github.com/wrf-model/WRF/wiki/Workflow-for-WRF-Code-Modification WRF instructions]. Note that the current WRF is at {{wrf-fire-merge-tag\|v4.0.3}} which is a few commits behind {{wrf-branch\|develop}}.		* I started {{wrf-fire-merge-branch\|fuel-moisture-model}} from {{wrf-branch\|develop}} as requested in [https://github.com/wrf-model/WRF/wiki/Workflow-for-WRF-Code-Modification WRF instructions]. Note that the current WRF is at {{wrf-fire-merge-tag\|v4.0.3}} which is a few commits behind {{wrf-branch\|develop}}.
	* Cherry pick {{wrf-fire-commit\|f8193dad36\|2011-09-25 adding moisture variables}} and {{wrf-fire-commit\|5a6c4b8c06\|2011-09-26 21:55:09 using variable fuel moisture in fmc_g}}. Making minimal changes against original. I had to check and understand any changes not just resolve the conflicts. Hard to automate. So that took a bit of time.		* Cherry pick {{wrf-fire-commit\|f8193dad36\|2011-09-25 adding moisture variables}} and {{wrf-fire-commit\|5a6c4b8c06\|2011-09-26 21:55:09 using variable fuel moisture in fmc_g}}. Making minimal changes against original. I had to check and understand any changes not just resolve the conflicts. Hard to automate. So that took a bit of time.
Line 10:		Line 6:
	* This is how it is in this stage of the code for testing, but the use of <tt>fire_fmc_read</tt> has changed in further commits after 2011-09-26 so the inputs will be different after the port is completed.		* This is how it is in this stage of the code for testing, but the use of <tt>fire_fmc_read</tt> has changed in further commits after 2011-09-26 so the inputs will be different after the port is completed.

	===Testing of <tt>fmc_g</tt> added===		==Testing of <tt>fmc_g</tt> added==
	Get the test code:		Get the test code:
	<pre>		<pre>
Line 33:		Line 29:
	To run real problem, build WPS for this WRF. Variable fmc_g should be in wrfinput but not set, you have to set it by other means.		To run real problem, build WPS for this WRF. Variable fmc_g should be in wrfinput but not set, you have to set it by other means.

	===Testing to be done===		==Testing to be done==
	* Compare builds and execution paths:		* Compare builds and execution paths:
	** Build from {{wrf-fire-merge-branch\|develop}} vs. {{wrf-fire-merge-branch\|added-fmc_g}}, both with fire_fmc_read not present in namelist.input. The numbers should be exactly the same.		** Build from {{wrf-fire-merge-branch\|develop}} vs. {{wrf-fire-merge-branch\|added-fmc_g}}, both with fire_fmc_read not present in namelist.input. The numbers should be exactly the same.
Line 43:		Line 39:
	* Real problems need to be tested, with data processed by WPS4		* Real problems need to be tested, with data processed by WPS4

	===Continued progress===		==Continued progress==
	The WRF4 code with the fuel moisture model from wrf-fire is being created in {{wrf-fire-merge-branch\|fuel-moisture-model}}. It is not ready for testing yet. Note that the merge is started from {{wrf-branch\|develop}} as requested in [https://github.com/wrf-model/WRF/wiki/Workflow-for-WRF-Code-Modification WRF instructions]. The current WRF is at {{wrf-fire-merge-tag\|v4.0.3}} which is few commits behind {{wrf-branch\|develop}}.		The WRF4 code with the fuel moisture model from wrf-fire is being created in {{wrf-fire-merge-branch\|fuel-moisture-model}}. It is not ready for testing yet. Note that the merge is started from {{wrf-branch\|develop}} as requested in [https://github.com/wrf-model/WRF/wiki/Workflow-for-WRF-Code-Modification WRF instructions]. The current WRF is at {{wrf-fire-merge-tag\|v4.0.3}} which is few commits behind {{wrf-branch\|develop}}.
	]
	~~</div>~~
	~~</div>~~

	==See also==		==See also==

Jmandel at 18:48, 3 February 2019

2019-02-03T18:48:28Z

← Older revision		Revision as of 18:48, 3 February 2019
Line 2:		Line 2:
	<div class="NavFrame collapsed">		<div class="NavFrame collapsed">
	<div class="NavHead">[Initial stage notes]</div>		<div class="NavHead">[Initial stage notes]</div>
	<div class="NavContent">		<div class="NavContent">
			[
	===Initial progress===		===Initial progress===
	* I started {{wrf-fire-merge-branch\|fuel-moisture-model}} from {{wrf-branch\|develop}} as requested in [https://github.com/wrf-model/WRF/wiki/Workflow-for-WRF-Code-Modification WRF instructions]. Note that the current WRF is at {{wrf-fire-merge-tag\|v4.0.3}} which is a few commits behind {{wrf-branch\|develop}}.		* I started {{wrf-fire-merge-branch\|fuel-moisture-model}} from {{wrf-branch\|develop}} as requested in [https://github.com/wrf-model/WRF/wiki/Workflow-for-WRF-Code-Modification WRF instructions]. Note that the current WRF is at {{wrf-fire-merge-tag\|v4.0.3}} which is a few commits behind {{wrf-branch\|develop}}.
Line 44:		Line 45:
	===Continued progress===		===Continued progress===
	The WRF4 code with the fuel moisture model from wrf-fire is being created in {{wrf-fire-merge-branch\|fuel-moisture-model}}. It is not ready for testing yet. Note that the merge is started from {{wrf-branch\|develop}} as requested in [https://github.com/wrf-model/WRF/wiki/Workflow-for-WRF-Code-Modification WRF instructions]. The current WRF is at {{wrf-fire-merge-tag\|v4.0.3}} which is few commits behind {{wrf-branch\|develop}}.		The WRF4 code with the fuel moisture model from wrf-fire is being created in {{wrf-fire-merge-branch\|fuel-moisture-model}}. It is not ready for testing yet. Note that the merge is started from {{wrf-branch\|develop}} as requested in [https://github.com/wrf-model/WRF/wiki/Workflow-for-WRF-Code-Modification WRF instructions]. The current WRF is at {{wrf-fire-merge-tag\|v4.0.3}} which is few commits behind {{wrf-branch\|develop}}.
			]
	</div>		</div>
	</div>		</div>

← Older revision		Revision as of 03:53, 8 February 2019
Line 46:		Line 46:

	==See also==		==See also==
			* [[WRF-Fire merge testing]]
	* [[WRF-SFIRE fuel moisture model commits]]		* [[WRF-SFIRE fuel moisture model commits]]
	* [[Tracking WRF Fire/SFIRE changes]]		* [[Tracking WRF Fire/SFIRE changes]]