Fuel moisture model pull request final changes 2020: Difference between revisions
No edit summary |
No edit summary |
||
| Line 11: | Line 11: | ||
* perhaps remove fmoist_freq and just leave fmoist_dt | * perhaps remove fmoist_freq and just leave fmoist_dt | ||
* In module_fr_fire_driver.F, there is a comment about “time – assume | * In module_fr_fire_driver.F, there is a comment about “time – assume dt does not change”. Is that true or does the FFM work also with time varying dt? | ||
dt does not change”. Is that true or does the FFM work also with time | |||
varying dt? | |||
* does the FFM work with restart? | * does the FFM work with restart? | ||
* The call to fire_driver_em() has now fire_ifun_end = 2, where it | * The call to fire_driver_em() has now fire_ifun_end = 2, where it used to be 3. According to the code comments in module_fr_fire_driver.F, fire_ifun_end = 3 has to do with initialization of time step. Is that skipped now or embedded within fire_ifun_end = 2? | ||
used to be 3. According to the code comments in module_fr_fire_driver.F, | |||
fire_ifun_end = 3 has to do with initialization of time step. Is that | |||
skipped now or embedded within fire_ifun_end = 2? | |||
* How are the fuel classes initialized for a real case? It seems that | * How are the fuel classes initialized for a real case? It seems that the FM values are prescribed from the solution of the fuel moisture model? Could you document/explain that? | ||
the FM values are prescribed from the solution of the fuel moisture model? | |||
Could you document/explain that? | |||
Revision as of 06:07, 2 February 2020
Final changes:
- update the PR commit message, there should be 15 files modified
- km_opt=5 fix is in the develop branch, merge
- registry package using fmoist_run variable
- perhaps remove fmoist_freq and just leave fmoist_dt
- In module_fr_fire_driver.F, there is a comment about “time – assume dt does not change”. Is that true or does the FFM work also with time varying dt?
- does the FFM work with restart?
- The call to fire_driver_em() has now fire_ifun_end = 2, where it used to be 3. According to the code comments in module_fr_fire_driver.F, fire_ifun_end = 3 has to do with initialization of time step. Is that skipped now or embedded within fire_ifun_end = 2?
- How are the fuel classes initialized for a real case? It seems that the FM values are prescribed from the solution of the fuel moisture model? Could you document/explain that?