Difference between revisions of "Fire code in WRF release"
Line 11: | Line 11: | ||
== List of changes== | == List of changes== | ||
+ | ===Unexpected changes=== | ||
* The wind reduction factors feature was removed [https://github.com/jbeezley/wrf-fire/commit/9a4e38390e19b612be459c4aacfdfb427ca472ba#L5L254] [https://github.com/jbeezley/wrf-fire/commit/9a4e38390e19b612be459c4aacfdfb427ca472ba#L5L506]. This in effect limits the code to ideal runs with a single fuel. | * The wind reduction factors feature was removed [https://github.com/jbeezley/wrf-fire/commit/9a4e38390e19b612be459c4aacfdfb427ca472ba#L5L254] [https://github.com/jbeezley/wrf-fire/commit/9a4e38390e19b612be459c4aacfdfb427ca472ba#L5L506]. This in effect limits the code to ideal runs with a single fuel. | ||
* Comments were removed and replaced [https://github.com/jbeezley/wrf-fire/commit/9a4e38390e19b612be459c4aacfdfb427ca472ba#L0L3] [https://github.com/jbeezley/wrf-fire/commit/9a4e38390e19b612be459c4aacfdfb427ca472ba#L1L2] [https://github.com/jbeezley/wrf-fire/commit/9a4e38390e19b612be459c4aacfdfb427ca472ba#L2L1] [https://github.com/jbeezley/wrf-fire/commit/9a4e38390e19b612be459c4aacfdfb427ca472ba#L5L486] [https://github.com/jbeezley/wrf-fire/commit/9a4e38390e19b612be459c4aacfdfb427ca472ba#L6L2], plus a number of smaller edits. | * Comments were removed and replaced [https://github.com/jbeezley/wrf-fire/commit/9a4e38390e19b612be459c4aacfdfb427ca472ba#L0L3] [https://github.com/jbeezley/wrf-fire/commit/9a4e38390e19b612be459c4aacfdfb427ca472ba#L1L2] [https://github.com/jbeezley/wrf-fire/commit/9a4e38390e19b612be459c4aacfdfb427ca472ba#L2L1] [https://github.com/jbeezley/wrf-fire/commit/9a4e38390e19b612be459c4aacfdfb427ca472ba#L5L486] [https://github.com/jbeezley/wrf-fire/commit/9a4e38390e19b612be459c4aacfdfb427ca472ba#L6L2], plus a number of smaller edits. | ||
Line 18: | Line 19: | ||
* Identification of the git commit the files come from was deleted [https://github.com/jbeezley/wrf-fire/commit/9a4e38390e19b612be459c4aacfdfb427ca472ba#L2L136] [https://github.com/jbeezley/wrf-fire/commit/9a4e38390e19b612be459c4aacfdfb427ca472ba#L6L1322]. | * Identification of the git commit the files come from was deleted [https://github.com/jbeezley/wrf-fire/commit/9a4e38390e19b612be459c4aacfdfb427ca472ba#L2L136] [https://github.com/jbeezley/wrf-fire/commit/9a4e38390e19b612be459c4aacfdfb427ca472ba#L6L1322]. | ||
* The examples were replaced,. | * The examples were replaced,. | ||
− | + | ===Routine software engineering changes=== | |
+ | * ONLY was added to USE statements [https://github.com/jbeezley/wrf-fire/commit/9a4e38390e19b612be459c4aacfdfb427ca472ba#L2L1] [https://github.com/jbeezley/wrf-fire/commit/9a4e38390e19b612be459c4aacfdfb427ca472ba#L2L798] [https://github.com/jbeezley/wrf-fire/commit/9a4e38390e19b612be459c4aacfdfb427ca472ba#L3L22] [https://github.com/jbeezley/wrf-fire/commit/9a4e38390e19b612be459c4aacfdfb427ca472ba#L6L1411] [https://github.com/jbeezley/wrf-fire/commit/9a4e38390e19b612be459c4aacfdfb427ca472ba#L6L1337] [https://github.com/jbeezley/wrf-fire/commit/9a4e38390e19b612be459c4aacfdfb427ca472ba#L6L1411] | ||
==Links== | ==Links== |
Revision as of 15:03, 11 July 2011
The links below lead to a web image of our repository. Scroll down for line-by-line list of differences. Removed lines are colored red and marked with -
. Added lines are colored green and marked with +
.
Comparison of the files
The differences in the fire module files between the submitted version and the release can be seen in this comparison.
How was the comparison obtained
To track the files, branch WRF_release_3.3 was created in our repository, starting from the files as submitted. One bug fix was applied, giving the final version submitted for the WRF release. We have then copied over separately the fire module files from the WRF 3.3 release at http://www.mmm.ucar.edu/wrf/src/WRFV3.3.TAR.gz, giving the comparison of the fire module files above. Finally, the rest of the files in the WRF release was copied over in order to get the final files in the release.
List of changes
Unexpected changes
- The wind reduction factors feature was removed [1] [2]. This in effect limits the code to ideal runs with a single fuel.
- Comments were removed and replaced [3] [4] [5] [6] [7], plus a number of smaller edits.
- Small (max about 1%) changes to default values of fuel data variables [8]
- Several variables were renamed [9] [10].
- Spread rate was changed in two cases [11] [12] by effectively counting the zero-wind rate twice later on [13] [14].
- Identification of the git commit the files come from was deleted [15] [16].
- The examples were replaced,.
Routine software engineering changes
Links
- Paper manuscript describing the code as submitted for the release
- WRF-Fire mailing list post announcing the changes
- Interactive discussion about the paper
- Comment stating that the release may be different
- Reply to the comment
- Summary of the differences
- Final version of the paper modified due to these changes