Difference between revisions of "Fire code in WRF release"

From openwfm
Jump to navigation Jump to search
 
(34 intermediate revisions by the same user not shown)
Line 1: Line 1:
The links below lead to a web image of our repository. Scroll down for line-by-line list of differences. Removed lines are colored red and marked with <code>-</code>. Added lines are colored green and marked with  <code>+</code>.
+
This page tracks the code as released with WRF under the name WRF-Fire.
  
==Comparison of the files==
+
==WRF 3.2==
  
The differences in the fire module files between the submitted version and the release can be seen in {{WRF-Fire-commit|9a4e38390e19b612be459c4aacfdfb427ca472ba|this comparison}}.
+
Code version of {{WRF-Fire-commit|b6fe89aeb71d941e91530aafcf2f5b183a44fc37|19 Feb 2010}} was [http://www.mmm.ucar.edu/wrf/users/wrfv3.2/updates-3.2.html released with WRF 3.2] on April, 2 2010.
  
==How was the comparison obtained==
+
==WRF 3.3==
  
To track the files, {{WRF-Fire-branch|WRF_release_3.3}} was created in our repository, starting from the {{WRF-Fire-commit|fa26d08d8154124ac51514b11bc671eb312e20f8|files as submitted}}. One {{WRF-Fire-commit|b964224219585ab198d58510c8f7a0cf129b1990|bug fix}} was applied, giving the {{WRF-Fire-commit|3f78267b38e0f0a36da49a58b8f00d00789ee67a|final version submitted for the WRF release}}. We have then copied over separately the fire module files from the WRF 3.3 release at http://www.mmm.ucar.edu/wrf/src/WRFV3.3.TAR.gz, giving the {{WRF-Fire-commit|9a4e38390e19b612be459c4aacfdfb427ca472ba|comparison of the fire module files}} above. Finally,  
+
The code we submitted for the WRF release was the version of {{WRF-Fire-commit|fa26d08d8154124ac51514b11bc671eb312e20f8|Nov 20, 2010}} with the bug fix {{WRF-Fire-commit|b964224219585ab198d58510c8f7a0cf129b1990|of Jan 17, 2011}}. The fire module files [http://www.mmm.ucar.edu/wrf/users/downloads.html released in WRF 3.3 on April 6, 2011] were modified at NCAR from the submitted version.
 +
 
 +
=== Differences from the submitted code===
 +
 
 +
:''Scroll down for line-by-line list of differences. Removed lines are colored red and marked with <code>-</code>. Added lines are colored green and marked with  <code>+</code>.''
 +
 
 +
* The wind reduction factors feature was removed [https://github.com/jbeezley/wrf-fire/commit/9a4e38390e19b612be459c4aacfdfb427ca472ba#L5L254] [https://github.com/jbeezley/wrf-fire/commit/9a4e38390e19b612be459c4aacfdfb427ca472ba#L5L506]. This in effect limits the code to ideal runs with a single fuel.
 +
* Comments were removed and replaced [https://github.com/jbeezley/wrf-fire/commit/9a4e38390e19b612be459c4aacfdfb427ca472ba#L0L3] [https://github.com/jbeezley/wrf-fire/commit/9a4e38390e19b612be459c4aacfdfb427ca472ba#L1L2] [https://github.com/jbeezley/wrf-fire/commit/9a4e38390e19b612be459c4aacfdfb427ca472ba#L2L1] [https://github.com/jbeezley/wrf-fire/commit/9a4e38390e19b612be459c4aacfdfb427ca472ba#L5L486] [https://github.com/jbeezley/wrf-fire/commit/9a4e38390e19b612be459c4aacfdfb427ca472ba#L6L2], plus a number of smaller edits.
 +
* Small (max about 1%) changes to default values of fuel data variables [https://github.com/jbeezley/wrf-fire/commit/9a4e38390e19b612be459c4aacfdfb427ca472ba#L5L123]
 +
* Several variables were renamed [https://github.com/jbeezley/wrf-fire/commit/9a4e38390e19b612be459c4aacfdfb427ca472ba#L5L701] [https://github.com/jbeezley/wrf-fire/commit/9a4e38390e19b612be459c4aacfdfb427ca472ba#L5R683].
 +
* Spread rate was changed in two cases [https://github.com/jbeezley/wrf-fire/commit/9a4e38390e19b612be459c4aacfdfb427ca472ba#L5L761] [https://github.com/jbeezley/wrf-fire/commit/9a4e38390e19b612be459c4aacfdfb427ca472ba#L5L776] by effectively counting the zero-wind rate twice later on [https://github.com/jbeezley/wrf-fire/blob/9a4e38390e19b612be459c4aacfdfb427ca472ba/wrfv2_fire/phys/module_fr_sfire_core.F#L1933] [https://github.com/jbeezley/wrf-fire/blob/9a4e38390e19b612be459c4aacfdfb427ca472ba/wrfv2_fire/phys/module_fr_sfire_core.F#L1743].
 +
* Identification of the git commit the files come from was deleted [https://github.com/jbeezley/wrf-fire/commit/9a4e38390e19b612be459c4aacfdfb427ca472ba#L2L136] [https://github.com/jbeezley/wrf-fire/commit/9a4e38390e19b612be459c4aacfdfb427ca472ba#L6L1322].
 +
* The examples were replaced.
 +
* Routine software engineering changes: ONLY was added to USE statements [https://github.com/jbeezley/wrf-fire/commit/9a4e38390e19b612be459c4aacfdfb427ca472ba#L2L1] [https://github.com/jbeezley/wrf-fire/commit/9a4e38390e19b612be459c4aacfdfb427ca472ba#L2L798] [https://github.com/jbeezley/wrf-fire/commit/9a4e38390e19b612be459c4aacfdfb427ca472ba#L3L22] [https://github.com/jbeezley/wrf-fire/commit/9a4e38390e19b612be459c4aacfdfb427ca472ba#L6L1411] [https://github.com/jbeezley/wrf-fire/commit/9a4e38390e19b612be459c4aacfdfb427ca472ba#L6L1337] [https://github.com/jbeezley/wrf-fire/commit/9a4e38390e19b612be459c4aacfdfb427ca472ba#L6L1411]
 +
 
 +
Compare with [http://mailman.ucar.edu/pipermail/wrf-fire/2011-April/000053.html WRF-Fire mailing list post] of April 7, 2011, announcing the changes in the code in the WRF release.
 +
 
 +
===How was the comparison obtained===
 +
 
 +
To track the files, we have created the branch {{WRF-Fire-branch|WRF_release}} in our git repository, starting from the {{WRF-Fire-commit|fa26d08d8154124ac51514b11bc671eb312e20f8|files as submitted}}. One {{WRF-Fire-commit|b964224219585ab198d58510c8f7a0cf129b1990|bug fix}} was applied, giving the {{WRF-Fire-commit|3f78267b38e0f0a36da49a58b8f00d00789ee67a|final version submitted for the WRF release}}. We have then copied over separately the fire module files from the WRF 3.3 release at http://www.mmm.ucar.edu/wrf/src/WRFV3.3.TAR.gz, giving the {{WRF-Fire-commit|9a4e38390e19b612be459c4aacfdfb427ca472ba|comparison of the fire module files}} above. Finally,  
 
the rest of the files in the WRF release was copied over in order to get the {{WRF-Fire-commit|b6fe157d04510be2b2b081e4478169e8e18f9601|final files in the release}}.
 
the rest of the files in the WRF release was copied over in order to get the {{WRF-Fire-commit|b6fe157d04510be2b2b081e4478169e8e18f9601|final files in the release}}.
 +
 +
===Resulting changes in the model description paper===
 +
 +
* [http://www.geosci-model-dev-discuss.net/4/497/2011/gmdd-4-497-2011.html Paper manuscript], accepted for discussion on March 2, 2011, describing the fire code as submitted for the WRF release.
 +
* [http://www.geosci-model-dev-discuss.net/4/497/2011/gmdd-4-497-2011-discussion.html Interactive discussion] about the paper.
 +
** [http://www.geosci-model-dev-discuss.net/4/C136/2011 Comment] of April 18, 2011, stating that the release may be different.
 +
** [http://www.geosci-model-dev-discuss.net/4/C145/2011 Reply to the comment] on April 26, 2011 .
 +
** [http://www.geosci-model-dev-discuss.net/4/C329/2011 Summary of the differences] on June 4, 2011.
 +
* [http://www.geosci-model-dev.net/4/591/2011/gmd-4-591-2011.html Final version] of the model description paper published July 7, 2011 with modifications, including a different title, which were necessary because of the code changes in the WRF release.
 +
 +
===Resulting changes in the Users Guide===
 +
* Since the guide distributed as appendix in [http://www.mmm.ucar.edu/wrf/users/docs/user_guide_V3/contents.html WRF Users's Guide] is not updated to the current code, the fire code {{openwfm|Users_Guide|Users Guide}} was moved to the openwfm.org wiki in August 2011. This also made it possible to grow the guide by the existing wiki {{openwfm|List_of_howtos|howtos}} reused as [http://www.openwfm.org/w/index.php5?title=Coupled_atmosphere-wildland_fire_model_WRF_and_SFIRE_users%27_guide&action=history chapters].
 +
 +
==WRF 3.4==
 +
 +
We did not submit a new version of the fire code for [http://www2.mmm.ucar.edu/wrf/users/downloads.html WRF 3.4, released on April 6, 2012].
 +
 +
The only differences in the fire module files between the 3.3 and 3.4 releases are due to routine software maintenance done at NCAR:
 +
 +
* More variables were added  [https://github.com/openwfm/wrf-fire/commit/97f1638a6b851ff31af3fc10d99651c6d717b85a#L0R11] to the fire_sfire package description in file {{WRF-Fire-file|wrfv2_fire/Registry/registry.fire|registry.fire}}, to save space when WRF is compiled without the fire option.
 +
* Some uninitialized variables were corrected [https://github.com/openwfm/wrf-fire/commit/97f1638a6b851ff31af3fc10d99651c6d717b85a#L1R1735] [https://github.com/jbeezley/wrf-fire/commit/97f1638a6b851ff31af3fc10d99651c6d717b85a#L1R1768] [https://github.com/openwfm/wrf-fire/commit/97f1638a6b851ff31af3fc10d99651c6d717b85a#L2R1212] in dead code left over from experiments in {{WRF-Fire-commit|4b5d8b21fde1c37831ce0f01a113ac41749b024d|2008}} and {{WRF-Fire-commit|979119d03b36bd6d979c73602adf02e56b9514cb|2010}}. Following up, we have {{WRF-Fire-commit|63d96c42b5846106222cfd6abfb93ee5982095b2|cleaned up the dead code}} in our repository.
 +
 +
To track the changes in the code in the WRF release, we have {{WRF-Fire-commit|97f1638a6b851ff31af3fc10d99651c6d717b85a|copied}} the fire module code from  [http://www.mmm.ucar.edu/wrf/users/download/get_source.html WRF 3.4]
 +
over the files in {{WRF-Fire-branch|WRF_release}}. To keep tracking in future, we have then {{WRF-Fire-commit|75dd8065be707af84d00b40c47eddfa7d5b4cd8b|copied}} the rest of the files from the WRF release in {{WRF-Fire-branch|WRF_release}}.
 +
 +
==WRF 3.5==
 +
 +
We did not submit a new version of the fire code for 3.5 release. The only change in the fire code in this release were done at NCAR and consisted of renaming of SFIRE  to FIRE everywhere, including all file names, subroutine names, and message strings.
 +
 +
==See also==
 +
* [[WRF Fire/SFIRE changes]]
 +
* {{openwfm|WRF-Fire_development_notes|WRF-Fire development notes}}
 +
* {{openwfm|WRF-Fire|WRF-Fire}}
 +
* {{openwfm|SFIRE|SFIRE}}

Latest revision as of 22:45, 20 January 2019

This page tracks the code as released with WRF under the name WRF-Fire.

WRF 3.2

Code version of 19 Feb 2010 was released with WRF 3.2 on April, 2 2010.

WRF 3.3

The code we submitted for the WRF release was the version of Nov 20, 2010 with the bug fix of Jan 17, 2011. The fire module files released in WRF 3.3 on April 6, 2011 were modified at NCAR from the submitted version.

Differences from the submitted code

Scroll down for line-by-line list of differences. Removed lines are colored red and marked with -. Added lines are colored green and marked with +.
  • The wind reduction factors feature was removed [1] [2]. This in effect limits the code to ideal runs with a single fuel.
  • Comments were removed and replaced [3] [4] [5] [6] [7], plus a number of smaller edits.
  • Small (max about 1%) changes to default values of fuel data variables [8]
  • Several variables were renamed [9] [10].
  • Spread rate was changed in two cases [11] [12] by effectively counting the zero-wind rate twice later on [13] [14].
  • Identification of the git commit the files come from was deleted [15] [16].
  • The examples were replaced.
  • Routine software engineering changes: ONLY was added to USE statements [17] [18] [19] [20] [21] [22]

Compare with WRF-Fire mailing list post of April 7, 2011, announcing the changes in the code in the WRF release.

How was the comparison obtained

To track the files, we have created the branch branch WRF_release in our git repository, starting from the files as submitted. One bug fix was applied, giving the final version submitted for the WRF release. We have then copied over separately the fire module files from the WRF 3.3 release at http://www.mmm.ucar.edu/wrf/src/WRFV3.3.TAR.gz, giving the comparison of the fire module files above. Finally, the rest of the files in the WRF release was copied over in order to get the final files in the release.

Resulting changes in the model description paper

Resulting changes in the Users Guide

  • Since the guide distributed as appendix in WRF Users's Guide is not updated to the current code, the fire code Users Guide was moved to the openwfm.org wiki in August 2011. This also made it possible to grow the guide by the existing wiki howtos reused as chapters.

WRF 3.4

We did not submit a new version of the fire code for WRF 3.4, released on April 6, 2012.

The only differences in the fire module files between the 3.3 and 3.4 releases are due to routine software maintenance done at NCAR:

  • More variables were added [23] to the fire_sfire package description in file registry.fire, to save space when WRF is compiled without the fire option.
  • Some uninitialized variables were corrected [24] [25] [26] in dead code left over from experiments in 2008 and 2010. Following up, we have cleaned up the dead code in our repository.

To track the changes in the code in the WRF release, we have copied the fire module code from WRF 3.4 over the files in branch WRF_release. To keep tracking in future, we have then copied the rest of the files from the WRF release in branch WRF_release.

WRF 3.5

We did not submit a new version of the fire code for 3.5 release. The only change in the fire code in this release were done at NCAR and consisted of renaming of SFIRE to FIRE everywhere, including all file names, subroutine names, and message strings.

See also