Fuel moisture model pull request final changes 2020

From openwfm
Jump to navigation Jump to search


Fuel moisture model should not change results

https://github.com/wrf-model/WRF/pull/792#issuecomment-582070283

  • /glade/work/jmandel/merge/WRF-Fire-merge-with-develop-dm at 46b548370c9eff7c9 (right after merge develop at 33bf83c664426b2674)

Update the PR commit message

there should be 15 files modified

km_opt=5 fix now in the develop branch, merge

/glade/u/home/jmandel/merge/WRF-Fire-merge-base-dm tag fuel-moisture-model-base-dec10-2019 at f9559af4b8a835f71 vs. /glade/u/home/jmandel/merge/WRF-Fire-merge-with-develop-dm branch fuel-moisture-model-merged-with-develop at 46b548370c9eff7c9

  • /glade/u/home/jmandel/merge/WRF-Fire-merge-base-dm/test/em_fire/rain/ vs /glade/u/home/jmandel/merge/WRF-Fire-merge-with-develop-dm/test/em_fire/rain: no change with np=16

Fire group comments

registry package using fmoist_run variable

also fmoist_interp:

  • based on /glade/work/jmandel/merge/WRF-Fire-merge-with-develop at 46b548370c9eff7c9a8bb7
  • fmoist_run: /glade/work/jmandel/merge/WRF-Fire-merge-package branch fuel-moisture-model-package at 46066cd0de4dd4f3f9a8ae83b7e5329d3ff
  • fmoist_interp: /glade/work/jmandel/merge/WRF-Fire-merge-package-interp branch fuel-moisture-model-package at d564d7da21e33eaec9f

perhaps remove fmoist_freq and just leave fmoist_dt

fixed dt only

In module_fr_fire_driver.F, there is a comment about “time – assume dt does not change”. Is that true or does the FFM work also with time varying dt?

Fixed dt only. Has not been a problem so far.

does the FFM work with restart?

fire_ifun_end

  • The call to fire_driver_em() has now fire_ifun_end = 2, where it used to be 3. According to the code comments in module_fr_fire_driver.F, fire_ifun_end = 3 has to do with initialization of time step. Is that skipped now or embedded within fire_ifun_end = 2?

fuel classes initialized for a real case

  • How are the fuel classes initialized for a real case? It seems that the FM values are prescribed from the solution of the fuel moisture model? Could you document/explain that?